flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3554] [streaming] Emit a MAX Watermark ...
Date Tue, 01 Mar 2016 13:39:17 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1750#discussion_r54566902
  
    --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/SourceFunctionTest.java
---
    @@ -61,9 +61,9 @@ public void generateSequenceTest() throws Exception {
     		assertEquals(expectedList, actualList);
     	}
     
    -	@Test
    -	public void socketTextStreamTest() throws Exception {
    -		// TODO: does not work because we cannot set the internal socket anymore
    +// TODO: does not work because we cannot set the internal socket anymore
    +//	@Test
    +//	public void socketTextStreamTest() throws Exception {
    --- End diff --
    
    Why not removing this test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message