flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3474] support partial aggregate
Date Mon, 07 Mar 2016 10:21:38 GMT
Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1746#issuecomment-193194745
  
    Thanks Chengxiang for the update. I think we can merge the PR now.
    
    But we should open a JIRA and improve the LongAvg aggregation. The communication between
Mapper and GroupReduce for aggregation is Flink internal and there is no need to expose this
to Calcite. I am not sure if our abstraction is well chosen, i.e., that a single DataSetNode
should only translate to a single DataSet operator. Maybe we should do another refactoring
before merging back to master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message