flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3574] Implement math functions for Tabl...
Date Wed, 09 Mar 2016 10:15:30 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1775#discussion_r55497175
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/call.scala
---
    @@ -61,3 +70,11 @@ object BuiltInFunctionConstants {
       val TRIM_TRAILING = Literal(2)
       val TRIM_DEFAULT_CHAR = Literal(" ")
     }
    +
    +object BuiltInMethods {
    +  val LOG10 = Types.lookupMethod(classOf[Math], "log10", classOf[Double])
    +  val EXP = Types.lookupMethod(classOf[Math], "exp", classOf[Double])
    +  val POWER = Types.lookupMethod(classOf[Math], "pow", classOf[Double], classOf[Double])
    +  val LN = Types.lookupMethod(classOf[Math], "log", classOf[Double])
    +  val ABS = Types.lookupMethod(classOf[SqlFunctions], "abs", classOf[Double])
    +}
    --- End diff --
    
    this file causes a scalastyle violation on travis:
    
    ```
    error file=/home/travis/build/apache/flink/flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/call.scala
message=File must end with newline character
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message