flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: FLINK-3529 Add template for pull requests
Date Thu, 10 Mar 2016 14:41:16 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1729#discussion_r55687974
  
    --- Diff: CONTRIBUTING.md ---
    @@ -8,4 +8,4 @@ To make the process smooth for the project *committers* (those who review
and ac
     
     Please check out the [How to Contribute guide](http://flink.apache.org/how-to-contribute.html)
to understand how contributions are made.
     There is also a list of [Coding Guidelines](http://flink.apache.org/coding-guidelines.html)
that you should follow.
    -
    +Moreover, there's a [check list](PULL_REQUEST_TEMPLATE.md) of what to do before opening
a pull request here
    --- End diff --
    
    This is not a full sentence. How about: "For pull requests, there is a [check list](PULL_REQUEST_TEMPLATE.md)
with criteria taken from the How to Contribute Guide and the Coding Guidelines."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message