flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...
Date Fri, 11 Mar 2016 13:56:01 GMT
Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1741#issuecomment-195374162
  
    Overall, the change looks good. I'm happy to see that the YARN tests haven't been touched
much. As long as these tests are present, most of the features users need should work properly.
    Also my tests on a secured virtual machine were successful.
    
    I don't have the time to check in detail if all the message sequences and different procedures
are implemented correctly but given that everything worked when I tested it, I'm positive
that we can merge the change soon.
    
    I think a quick review by @StephanEwen and @tillrohrmann would be good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message