flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...
Date Fri, 11 Mar 2016 14:00:29 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1741#discussion_r55831616
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
---
    @@ -682,27 +729,27 @@
     	 */
     	public static final int DEFAULT_FS_STREAM_OPENING_TIMEOUT = 0;
     
    -	// ------------------------ YARN Configuration ------------------------
    +
    +	// ------ Common Resource Framework Configuration (YARN & Mesos) ------
     
     	/**
    -	 * Minimum amount of Heap memory to subtract from the requested TaskManager size.
    -	 * We came up with these values experimentally.
    -	 * Flink fails when the cutoff is set only to 500 mb.
    +	 * Minimum amount of memory to subtract from the process memory to get the TaskManager
    +	 * heap size. We came up with these values experimentally.
     	 */
    -	public static final int DEFAULT_YARN_MIN_HEAP_CUTOFF = 600;
    +	public static final int DEFAULT_CONTAINERED_MIN_HEAP_CUTOFF = 600;
     
     	/**
    -	 * Relative amount of memory to subtract from the requested memory.
    +	 * Relative amount of memory to subtract from Java process memory to get the TaskManager
    +	 * heap size
     	 */
    -	public static final float DEFAULT_YARN_HEAP_CUTOFF_RATIO = 0.25f;
    +	public static final float DEFAULT_CONTAINERED_HEAP_CUTOFF_RATIO = 0.25f;
    --- End diff --
    
    I see. Will revert the change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message