flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3574] Implement math functions for Tabl...
Date Sat, 12 Mar 2016 17:13:29 GMT
Github user twalthr commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/call.scala
    @@ -61,3 +70,11 @@ object BuiltInFunctionConstants {
       val TRIM_TRAILING = Literal(2)
       val TRIM_DEFAULT_CHAR = Literal(" ")
    +object BuiltInMethods {
    --- End diff --
    I wouldn't place the BuiltInMethods here because we then mix user-facing API and runtime.
Can you put it either into `MethodCallGenerator` or into its package?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message