flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: FLINK-3398: Allow for opting-out from Kafka of...
Date Mon, 14 Mar 2016 14:34:30 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1690#discussion_r56009318
  
    --- Diff: flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer08.java
---
    @@ -295,7 +296,7 @@ public void open(Configuration parameters) throws Exception {
     
     	@Override
     	public void run(SourceContext<T> sourceContext) throws Exception {
    -		if (fetcher != null) {
    +		if (fetcher != null && isAutoCommitEnabled()) {
    --- End diff --
    
    This is not correct!
    If the fetcher != null and auto commit disabled, `fetcher.run()` (line 316) is never called!
This means that the fetcher is doing anything at all!
    
    I'm not sure how the integration tests were passing with that change! (maybe there is
no test testing auto commit enable = false.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message