flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shikhar <...@git.apache.org>
Subject [GitHub] flink pull request: FLINK-3398: Allow for opting-out from Kafka of...
Date Thu, 17 Mar 2016 03:14:49 GMT
Github user shikhar commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1690#discussion_r56450314
  
    --- Diff: flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer08.java
---
    @@ -295,7 +296,7 @@ public void open(Configuration parameters) throws Exception {
     
     	@Override
     	public void run(SourceContext<T> sourceContext) throws Exception {
    -		if (fetcher != null) {
    +		if (fetcher != null && isAutoCommitEnabled()) {
    --- End diff --
    
    Ikes! Added that on the wrong conditional, it was supposed to be on the `!streamingRuntimeContext.isCheckpointingEnabled()`
clause where `PeriodicOffsetCommitter` is initialized.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message