flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...
Date Tue, 22 Mar 2016 11:07:11 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1741#discussion_r56968619
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
    @@ -592,19 +605,18 @@ class TaskManager(
                 log.warn(s"Ignoring 'AcknowledgeRegistration' message from ${jobManager.path}
, " +
                   s"because the TaskManager is already registered at ${currentJobManager.orNull}")
               }
    -        }
    -        else {
    +        } else {
               // not yet connected, so let's associate with that JobManager
               try {
                 associateWithJobManager(jobManager, id, blobPort)
               } catch {
                 case t: Throwable =>
                   killTaskManagerFatal(
    -                "Unable to start TaskManager components after registering at JobManager",
t)
    +                "Unable to start TaskManager components and associate with the JobManager
", t)
               }
             }
     
    -      // we are already registered at that specific JobManager - duplicate answer, rare
cases
    +      // we are already registered at this ResourceManager - duplicate answer, rare cases
           case AlreadyRegistered(id, blobPort) =>
             val jobManager = sender()
    --- End diff --
    
    Is this the JM or the RM address which we store here in `jobManager`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message