flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3398) Flink Kafka consumer should support auto-commit opt-outs
Date Mon, 21 Mar 2016 14:34:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204353#comment-15204353
] 

ASF GitHub Bot commented on FLINK-3398:
---------------------------------------

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1690#issuecomment-199316872
  
    Let me summarize the change:
    
    ```
    auto.commit.enable=true checkpointing=true    offsets go to ZK/Broker on each completed
checkpoint
    auto.commit.enable=false checkpointing=true   offsets are only available for recovery
with Flink, not in ZK / broker
    auto.commit.enable=true checkpointing=false   offsets are written to ZK periodically
    auto.commit.enable=false checkpointing=false  offsets are not in ZK or in Flink
    ```
    
    I don't like this variant:
    ```
    auto.commit.enable=false checkpointing=true   offsets are only available for recovery
with Flink, not in ZK / broker
    ```
    because it stretches the original definition of "auto.commit.enable" a bit. In my understanding,
"auto.commit.enable" in Kafka starts a periodic committer, for sending the offsets to ZK /
broker.
    
    In Flink, the semantic of the setting is more or less "enable offset committing".
    How about we limit the "auto.commit.enable" setting only to the periodic offset committing
thread?


> Flink Kafka consumer should support auto-commit opt-outs
> --------------------------------------------------------
>
>                 Key: FLINK-3398
>                 URL: https://issues.apache.org/jira/browse/FLINK-3398
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Shikhar Bhushan
>
> Currently the Kafka source will commit consumer offsets to Zookeeper, either upon a checkpoint
if checkpointing is enabled, otherwise periodically based on {{auto.commit.interval.ms}}
> It should be possible to opt-out of committing consumer offsets to Zookeeper. Kafka has
this config as {{auto.commit.enable}} (0.8) and {{enable.auto.commit}} (0.9).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message