flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3489) Refactor Table API before merging into master
Date Mon, 14 Mar 2016 13:44:33 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193303#comment-15193303
] 

ASF GitHub Bot commented on FLINK-3489:
---------------------------------------

GitHub user vasia opened a pull request:

    https://github.com/apache/flink/pull/1789

    [FLINK-3489] TableAPI refactoring and cleanup

    I applied the proposed changes, except from
    - remove `ExpressionException `: it is used in many places
    - remove `typeInfo()` of `Expression`: also used in several places
    - add the `ExecutionEnvironment` to the `TableEnvironment`: we probably also need to add
the `StreamExecutionEnvironment` to the `TableEnvironment` and figure out a way to know if
we have a batch or stream Table, so it might be a good idea to perform this change as part
of a different issue.
    
    Another thing could do is move the DataSet rules to the `org.apache.flink.api.table.plan.rules`
package and remove the `org.apache.flink.api.table.plan.rules.dataset` package. Let me know
what you think about this. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vasia/flink refactorTable

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1789.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1789
    
----
commit 0c3679e9403c002d0761f1511dec2de597b94266
Author: vasia <vasia@apache.org>
Date:   2016-03-14T13:16:29Z

    [FLINK-3489] TableAPI refactoring and cleanup

----


> Refactor Table API before merging into master
> ---------------------------------------------
>
>                 Key: FLINK-3489
>                 URL: https://issues.apache.org/jira/browse/FLINK-3489
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API
>            Reporter: Timo Walther
>            Assignee: Vasia Kalavri
>
> Before we merge the `tableOnCalcite` branch back into master, we should do some package/class
refactoring. Here are some ideas:
> - Move class {{TreeNode}} into {{expressions}} or its methods directly into {{Expression}}.
> - Remove the {{org.apache.flink.api.table.trees}} package.
> - Rename {{org.apache.flink.api.table.typeinfo}} to {{typeutils}} to be in sync with
other Flink modules.
> - Move {{TypeConverter}} to {{typeutils}}
> - Remove {{ExpressionException}} it is currently only used by {{typeInfo()}} of {{Expression}}
> - Remove {{typeInfo()}} of {{Expression}} and subclasses. It is not used.
> - Add {{ExecutionEnvironment}} as parameter of {{TableEnvironment}} (necessary for Table
API specific input formats) in order to not break the API in future?
> - Remove {{println}} in translators.
> Feel free to propose other changes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message