flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3529) Add pull request template
Date Thu, 10 Mar 2016 14:41:40 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189373#comment-15189373
] 

ASF GitHub Bot commented on FLINK-3529:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1729#discussion_r55687974
  
    --- Diff: CONTRIBUTING.md ---
    @@ -8,4 +8,4 @@ To make the process smooth for the project *committers* (those who review
and ac
     
     Please check out the [How to Contribute guide](http://flink.apache.org/how-to-contribute.html)
to understand how contributions are made.
     There is also a list of [Coding Guidelines](http://flink.apache.org/coding-guidelines.html)
that you should follow.
    -
    +Moreover, there's a [check list](PULL_REQUEST_TEMPLATE.md) of what to do before opening
a pull request here
    --- End diff --
    
    This is not a full sentence. How about: "For pull requests, there is a [check list](PULL_REQUEST_TEMPLATE.md)
with criteria taken from the How to Contribute Guide and the Coding Guidelines."


> Add pull request template
> -------------------------
>
>                 Key: FLINK-3529
>                 URL: https://issues.apache.org/jira/browse/FLINK-3529
>             Project: Flink
>          Issue Type: Task
>          Components: other
>            Reporter: Martin Liesenberg
>            Assignee: Martin Liesenberg
>            Priority: Minor
>
> Add a template for pull requests, checking if prerequisites of opening a PR have been
fulfilled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message