flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3544) ResourceManager runtime components
Date Tue, 22 Mar 2016 11:07:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206177#comment-15206177
] 

ASF GitHub Bot commented on FLINK-3544:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1741#discussion_r56968619
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
    @@ -592,19 +605,18 @@ class TaskManager(
                 log.warn(s"Ignoring 'AcknowledgeRegistration' message from ${jobManager.path}
, " +
                   s"because the TaskManager is already registered at ${currentJobManager.orNull}")
               }
    -        }
    -        else {
    +        } else {
               // not yet connected, so let's associate with that JobManager
               try {
                 associateWithJobManager(jobManager, id, blobPort)
               } catch {
                 case t: Throwable =>
                   killTaskManagerFatal(
    -                "Unable to start TaskManager components after registering at JobManager",
t)
    +                "Unable to start TaskManager components and associate with the JobManager
", t)
               }
             }
     
    -      // we are already registered at that specific JobManager - duplicate answer, rare
cases
    +      // we are already registered at this ResourceManager - duplicate answer, rare cases
           case AlreadyRegistered(id, blobPort) =>
             val jobManager = sender()
    --- End diff --
    
    Is this the JM or the RM address which we store here in `jobManager`?


> ResourceManager runtime components
> ----------------------------------
>
>                 Key: FLINK-3544
>                 URL: https://issues.apache.org/jira/browse/FLINK-3544
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ResourceManager
>    Affects Versions: 1.1.0
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>             Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message