flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3544) ResourceManager runtime components
Date Tue, 22 Mar 2016 14:59:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206485#comment-15206485
] 

ASF GitHub Bot commented on FLINK-3544:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1741#discussion_r57000923
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/BootstrapToolsTest.java
---
    @@ -0,0 +1,109 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.clusterframework;
    +
    +import org.apache.flink.configuration.Configuration;
    +import org.junit.Test;
    +
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertFalse;
    +import static org.junit.Assert.assertNull;
    +
    +public class BootstrapToolsTest {
    +
    +	@Test
    +	public void testSubstituteConfigKey() {
    +		String deprecatedKey1 ="deprecated-key";
    +		String deprecatedKey2 ="another-out_of-date_key";
    +		String deprecatedKey3 ="yet-one-more";
    +
    +		String designatedKey1 ="newkey1";
    +		String designatedKey2 ="newKey2";
    +		String designatedKey3 ="newKey3";
    +
    +		String value1 = "value1";
    +		String value2_designated = "designated-value2";
    +		String value2_deprecated = "deprecated-value2";
    +
    +		// config contains only deprecated key 1, and for key 2 both deprecated and designated
    +		Configuration cfg = new Configuration();
    +		cfg.setString(deprecatedKey1, value1);
    +		cfg.setString(deprecatedKey2, value2_deprecated);
    +		cfg.setString(designatedKey2, value2_designated);
    +
    +		BootstrapTools.substituteDeprecatedConfigKey(cfg, deprecatedKey1, designatedKey1);
    +		BootstrapTools.substituteDeprecatedConfigKey(cfg, deprecatedKey2, designatedKey2);
    +		BootstrapTools.substituteDeprecatedConfigKey(cfg, deprecatedKey3, designatedKey3);
    +
    +		// value 1 should be set to designated
    +		assertEquals(value1, cfg.getString(designatedKey1, null));
    +
    +		// value 2 should not have been set, since it had a value already
    +		assertEquals(value2_designated, cfg.getString(designatedKey2, null));
    +
    +		// nothing should be in there for key 3
    +		assertNull(cfg.getString(designatedKey3, null));
    +		assertNull(cfg.getString(deprecatedKey3, null));
    +	}
    +
    +	@Test
    +	public void testSubstituteConfigKeyPrefix() {
    +		String deprecatedPrefix1 ="deprecated-prefix";
    +		String deprecatedPrefix2 ="-prefix-2";
    +		String deprecatedPrefix3 ="prefix-3";
    +
    +		String designatedPrefix1 ="p1";
    +		String designatedPrefix2 ="ppp";
    +		String designatedPrefix3 ="zzz";
    +
    +		String depr1 = deprecatedPrefix1 + "var";
    +		String depr2 = deprecatedPrefix2 + "env";
    +		String depr3 = deprecatedPrefix2 + "x";
    +
    +		String desig1 = deprecatedPrefix1 + "var";
    +		String desig2 = deprecatedPrefix2 + "env";
    +		String desig3 = deprecatedPrefix2 + "x";
    --- End diff --
    
    Nope. Good catch.


> ResourceManager runtime components
> ----------------------------------
>
>                 Key: FLINK-3544
>                 URL: https://issues.apache.org/jira/browse/FLINK-3544
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ResourceManager
>    Affects Versions: 1.1.0
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>             Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message