flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3544) ResourceManager runtime components
Date Fri, 11 Mar 2016 10:57:33 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190795#comment-15190795
] 

ASF GitHub Bot commented on FLINK-3544:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1741#discussion_r55816122
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
---
    @@ -682,27 +729,27 @@
     	 */
     	public static final int DEFAULT_FS_STREAM_OPENING_TIMEOUT = 0;
     
    -	// ------------------------ YARN Configuration ------------------------
    +
    +	// ------ Common Resource Framework Configuration (YARN & Mesos) ------
     
     	/**
    -	 * Minimum amount of Heap memory to subtract from the requested TaskManager size.
    -	 * We came up with these values experimentally.
    -	 * Flink fails when the cutoff is set only to 500 mb.
    +	 * Minimum amount of memory to subtract from the process memory to get the TaskManager
    +	 * heap size. We came up with these values experimentally.
     	 */
    -	public static final int DEFAULT_YARN_MIN_HEAP_CUTOFF = 600;
    +	public static final int DEFAULT_CONTAINERED_MIN_HEAP_CUTOFF = 600;
     
     	/**
    -	 * Relative amount of memory to subtract from the requested memory.
    +	 * Relative amount of memory to subtract from Java process memory to get the TaskManager
    +	 * heap size
     	 */
    -	public static final float DEFAULT_YARN_HEAP_CUTOFF_RATIO = 0.25f;
    +	public static final float DEFAULT_CONTAINERED_HEAP_CUTOFF_RATIO = 0.25f;
    --- End diff --
    
    You can not rename variables in the ConfigConstants because the class is publicly visible.


> ResourceManager runtime components
> ----------------------------------
>
>                 Key: FLINK-3544
>                 URL: https://issues.apache.org/jira/browse/FLINK-3544
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ResourceManager
>    Affects Versions: 1.1.0
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>             Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message