flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3556) Unneeded check in HA blob store configuration
Date Tue, 01 Mar 2016 12:36:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173688#comment-15173688
] 

ASF GitHub Bot commented on FLINK-3556:
---------------------------------------

GitHub user uce opened a pull request:

    https://github.com/apache/flink/pull/1749

    [FLINK-3556] [runtime] Remove false check in HA blob store configuration

    If you use the `RocksDBStateBackend` and configure HA w/o setting the state backend to
`filesystem`, restoring your job will fail, because the BLOBs are not persisted. The really
ugly part is that this does not log a warning  or anything. I'm leaning towards making this
a release blocker, but it can also be postponed to `1.0.1`, if that follows very soon.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/flink 3556-blob

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1749.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1749
    
----
commit 3b2b6a823c6b2931d9e95d1c8f1f759af2dd436a
Author: Ufuk Celebi <uce@apache.org>
Date:   2016-03-01T11:23:31Z

    [FLINK-3556] [runtime] Remove false check in HA blob store configuration

----


> Unneeded check in HA blob store configuration
> ---------------------------------------------
>
>                 Key: FLINK-3556
>                 URL: https://issues.apache.org/jira/browse/FLINK-3556
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>            Priority: Critical
>
> The BlobServer in HA mode checks whether `ConfigConstants.STATE_BACKEND` has been configured,
which is not needed.
> Remove the check and fail if recovery mode is ZooKeeper and no path has been configured.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message