flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3560) Examples shouldn't always print usage statement
Date Tue, 01 Mar 2016 16:31:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173982#comment-15173982
] 

ASF GitHub Bot commented on FLINK-3560:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/1752

    [FLINK-3560] [examples] Remove unchecked output of usage statement in examples

    This PR effectively removes all unconditioned outputs of the usage message of the examples.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixExamples

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1752.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1752
    
----
commit 54a6c036b96a1073bcf54734759437062f50b5ee
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2016-03-01T16:21:57Z

    [FLINK-3560] [examples] Remove unchecked output of usage statement in examples

----


> Examples shouldn't always print usage statement
> -----------------------------------------------
>
>                 Key: FLINK-3560
>                 URL: https://issues.apache.org/jira/browse/FLINK-3560
>             Project: Flink
>          Issue Type: Improvement
>          Components: Examples
>    Affects Versions: 1.0.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> At the moment all our examples print a usage statement no matter whether the parameters
have been provided or not. This can be confusing for people because an usage statement is
usually only printed if one has specified a wrong parameter or if a parameter is missing.
> I propose to remove the unchecked printing of the usage statement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message