flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3560) Examples shouldn't always print usage statement
Date Tue, 01 Mar 2016 17:06:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174030#comment-15174030
] 

ASF GitHub Bot commented on FLINK-3560:
---------------------------------------

Github user vasia commented on the pull request:

    https://github.com/apache/flink/pull/1752#issuecomment-190816975
  
    If we remove the default usage printing, I think it would be nice to make sure that all
examples implement `ProgramDescription`. This way, we can get the usage information if we
want to. Otherwise, we would get one message per default parameter. e.g. in the Kmeans example,
we would get:
    ```
    Executing K-Means example with default point data set.
    Use --points to specify file input.
    Executing K-Means example with default centroid data set.
    Use --centroids to specify file input.
    Printing result to stdout. Use --output to specify output path.
    ```
    instead of
    `Usage: KMeans --points <path> --centroids <path> --output <path> --iterations
<n>`


> Examples shouldn't always print usage statement
> -----------------------------------------------
>
>                 Key: FLINK-3560
>                 URL: https://issues.apache.org/jira/browse/FLINK-3560
>             Project: Flink
>          Issue Type: Improvement
>          Components: Examples
>    Affects Versions: 1.0.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> At the moment all our examples print a usage statement no matter whether the parameters
have been provided or not. This can be confusing for people because an usage statement is
usually only printed if one has specified a wrong parameter or if a parameter is missing.
> I propose to remove the unchecked printing of the usage statement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message