flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3595] [runtime] Eagerly destroy buffer ...
Date Thu, 10 Mar 2016 13:58:29 GMT
GitHub user uce opened a pull request:

    https://github.com/apache/flink/pull/1780

    [FLINK-3595] [runtime] Eagerly destroy buffer pools on cancelling

    When canceling a job, the Kafka 0.9 Consumer Thread may be stuck in a blocking method
(output emitting) and never wakes up.
    
    The thread as a whole cannot be simply interrupted, because of a bug in Kafka that makes
the consumer freeze/hang up on interrupt.
    
    With this PR, we destroy the buffer pools eagerly on canceling. The Kafka thread will
then throw an exception if it is stuck in emitting elements and it will terminate, which is
accepted in case the status is canceled.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/flink 3595-close_bufferpools

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1780.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1780
    
----
commit 52320e184f0af61d1d1bf5f9e81b9da2309033c5
Author: Ufuk Celebi <uce@apache.org>
Date:   2016-03-10T11:02:25Z

    [FLINK-3595] [runtime] Eagerly destroy buffer pools on cancelling

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message