flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mbalassi <...@git.apache.org>
Subject [GitHub] flink pull request: FLINK-3657: Change access of DataSetUtils.coun...
Date Fri, 01 Apr 2016 22:09:21 GMT
Github user mbalassi commented on the pull request:

    https://github.com/apache/flink/pull/1829#issuecomment-204587443
  
    I think @smarthi has a point that the functionality is a nice fit for `DataSetUtils` and
he has properly added it to the scala API and covered the tests.
    It is true that it has some minor refactoring obfuscating the core PR, but besides that
LGTM. If noone thinks otherwise I would merge this Tuesday morning with optionally excluding
the refactor parts if it is considered that bothersome.
    Unfortunately for the Mahout release I think the policy is as @fhueske suggests that we
should reserve new features for the next, 1.1.0 release line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message