flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3311/FLINK-3332] Add Cassandra connecto...
Date Tue, 05 Apr 2016 15:37:12 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1771#discussion_r58561096
  
    --- Diff: flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java
---
    @@ -0,0 +1,93 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.cassandra;
    +
    +import com.datastax.driver.core.Cluster;
    +import com.datastax.driver.core.Session;
    +import com.google.common.util.concurrent.FutureCallback;
    +import com.google.common.util.concurrent.Futures;
    +import com.google.common.util.concurrent.ListenableFuture;
    +import org.apache.flink.api.java.ClosureCleaner;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.streaming.api.functions.sink.RichSinkFunction;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.IOException;
    +
    +/**
    + * CassandraSinkBase is the common abstract class of {@link CassandraPojoSink} and {@link
CassandraTupleSink}.
    + *
    + * @param <IN> Type of the elements emitted by this sink
    + */
    +public abstract class CassandraSinkBase<IN, V> extends RichSinkFunction<IN>
{
    +	protected static final Logger LOG = LoggerFactory.getLogger(CassandraSinkBase.class);
    +	protected transient Cluster cluster;
    +	protected transient Session session;
    +
    +	protected transient Throwable exception = null;
    +	protected transient FutureCallback<V> callback;
    +
    +	private final ClusterBuilder builder;
    +
    +	protected CassandraSinkBase(ClusterBuilder builder) {
    +		this.builder = builder;
    +		ClosureCleaner.clean(builder, true);
    +	}
    +
    +	@Override
    +	public void open(Configuration configuration) {
    +		this.callback = new FutureCallback<V>() {
    +			@Override
    +			public void onSuccess(V ignored) {
    +			}
    +
    +			@Override
    +			public void onFailure(Throwable t) {
    +				exception = t;
    --- End diff --
    
    Can you log the exception as well. Maybe invoke() is never called after the failure and
nobody knows what's going on


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message