flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3697] Properly access type information ...
Date Tue, 05 Apr 2016 15:55:04 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1851#discussion_r58564424
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/FieldAccessor.java
---
    @@ -182,11 +182,14 @@ public R set(R record, F fieldValue) {
     			@SuppressWarnings("unchecked")
     			CompositeType<R> cType = (CompositeType<R>) type;
     
    +			if(field.contains(".")) {
    +				throw new IllegalArgumentException("The Pojo field accessor currently doesn't support
nested POJOs");
    --- End diff --
    
    Thank you for reviewing my pull request. I've opened FLINK-3702 for that.
    
    See also here: https://github.com/apache/flink/pull/1851/files#diff-e5e091a2c1e4bf850ef93e2010fe4c81R132


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message