flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3665] Implemented sort orders support i...
Date Thu, 07 Apr 2016 15:42:16 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1848#discussion_r58894245
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/base/PartitionOperatorBase.java
---
    @@ -51,12 +53,19 @@
     	private Partitioner<?> customPartitioner;
     	
     	private DataDistribution distribution;
    +
    +	private Ordering ordering;
     	
     	
     	public PartitionOperatorBase(UnaryOperatorInformation<IN, IN> operatorInfo, PartitionMethod
pMethod, int[] keys, String name) {
     		super(new UserCodeObjectWrapper<NoOpFunction>(new NoOpFunction()), operatorInfo,
keys, name);
     		this.partitionMethod = pMethod;
     	}
    +
    +	public PartitionOperatorBase(UnaryOperatorInformation<IN, IN> operatorInfo, PartitionMethod
pMethod, int[] keys, Order[] orders, String name) {
    --- End diff --
    
    I think this constructor is not used. So it can be removed. 
    Also `orders` is not set in this constructor. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message