flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3665] Implemented sort orders support i...
Date Mon, 18 Apr 2016 14:48:39 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1848#discussion_r60071774
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/Keys.java ---
    @@ -183,9 +193,13 @@ public String toString() {
     		
     		public static final String SELECT_ALL_CHAR = "*";
     		public static final String SELECT_ALL_CHAR_SCALA = "_";
    +		private static final Pattern WILD_CARD_REGEX = Pattern.compile("[\\.]?("
    +				+ "\\" + SELECT_ALL_CHAR + "\\B|"
    --- End diff --
    
    Can we terminate the patterns with `$` instead of `\b` and `\B`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message