flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3798] [streaming] Clean up RocksDB back...
Date Thu, 21 Apr 2016 09:05:05 GMT
Github user aljoscha commented on a diff in the pull request:

    --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBValueState.java
    @@ -64,7 +64,7 @@
     	 * @param stateDesc The state identifier for the state. This contains name
     	 *                           and can create a default state value.
    -	RocksDBValueState(ColumnFamilyHandle columnFamily,
    +	public RocksDBValueState(ColumnFamilyHandle columnFamily,
    --- End diff --
    Ah I see, you're right. Could you make all of the State constructors public then? Just
for consistency... 😃 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message