flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yjshen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...
Date Fri, 22 Apr 2016 12:03:33 GMT
Github user yjshen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1916#discussion_r60728312
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
    @@ -199,12 +151,12 @@ class Table(
         *   tab.filter('name === "Fred")
         * }}}
         */
    -  def filter(predicate: Expression): Table = {
    -
    -    relBuilder.push(relNode)
    -    relBuilder.filter(predicate.toRexNode(relBuilder))
    -    
    -    new Table(relBuilder.build(), tableEnv)
    +  def filter(predicate: Expression): Table = withPlan {
    +//    logicalPlan match {
    +//      case j: Join => j.copy(condition = Some(predicate))
    +//      case o => Filter(predicate, logicalPlan)
    +//    }
    --- End diff --
    
    Will remove this the next commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message