flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gna-phetsarath <...@git.apache.org>
Subject [GitHub] flink pull request: [Flink-3691] extend avroinputformat to support...
Date Wed, 27 Apr 2016 13:57:06 GMT
Github user gna-phetsarath commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1920#discussion_r61261060
  
    --- Diff: flink-batch-connectors/flink-avro/src/main/java/org/apache/flink/api/java/io/AvroInputFormat.java
---
    @@ -119,12 +144,18 @@ public E nextRecord(E reuseValue) throws IOException {
     		if (reachedEnd()) {
     			return null;
     		}
    -		
    -		if (!reuseAvroValue) {
    -			reuseValue = InstantiationUtil.instantiate(avroValueType, Object.class);
    +		if (isGenericRecord) {
    --- End diff --
    
    OK. I'll make the change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message