flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...
Date Thu, 28 Apr 2016 12:56:12 GMT
Github user fhueske commented on the pull request:

    If we decide for eager validation, we can also simplify the code a bit, right? 
    I might be wrong but we could remove `PlanPreparation` and the recursive validation of
`LogicalNode` since the inputs of an operator would have been already validated. The checks
of `Validator.validate()` could be moved to the respective `LogicalNode`. Not sure if we would
still need the `RuleExecutor`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message