flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3634) Fix documentation for DataSetUtils.zipWithUniqueId()
Date Thu, 07 Apr 2016 12:42:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230170#comment-15230170
] 

ASF GitHub Bot commented on FLINK-3634:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1817#issuecomment-206868628
  
    Thanks for the update @greghogan. +1 to merge.


> Fix documentation for DataSetUtils.zipWithUniqueId()
> ----------------------------------------------------
>
>                 Key: FLINK-3634
>                 URL: https://issues.apache.org/jira/browse/FLINK-3634
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 1.1.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>             Fix For: 1.1.0, 1.0.1
>
>
> Under FLINK-2590 the assignment and testing of unique IDs was improved but the documentation
looks to still reference the old implementation.
> With {{parallelism=1}} there is no difference between zipWithUniqueID and zipWithIndex.
With greater parallelism the results of zipWithUniqueID are dependent on the partitioning.
> The documentation should demonstrate a possible result that is different from the incremental
sequence of zipWithIndex while noting that results are dependent on the parallelism and partitioning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message