flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3657) Change access of DataSetUtils.countElements() to 'public'
Date Fri, 01 Apr 2016 22:09:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222423#comment-15222423
] 

ASF GitHub Bot commented on FLINK-3657:
---------------------------------------

Github user mbalassi commented on the pull request:

    https://github.com/apache/flink/pull/1829#issuecomment-204587443
  
    I think @smarthi has a point that the functionality is a nice fit for `DataSetUtils` and
he has properly added it to the scala API and covered the tests.
    It is true that it has some minor refactoring obfuscating the core PR, but besides that
LGTM. If noone thinks otherwise I would merge this Tuesday morning with optionally excluding
the refactor parts if it is considered that bothersome.
    Unfortunately for the Mahout release I think the policy is as @fhueske suggests that we
should reserve new features for the next, 1.1.0 release line.


> Change access of DataSetUtils.countElements() to 'public' 
> ----------------------------------------------------------
>
>                 Key: FLINK-3657
>                 URL: https://issues.apache.org/jira/browse/FLINK-3657
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataSet API
>    Affects Versions: 1.0.0
>            Reporter: Suneel Marthi
>            Assignee: Suneel Marthi
>            Priority: Minor
>             Fix For: 1.0.1
>
>
> The access of DatasetUtils.countElements() is presently 'private', change that to be
'public'. We happened to be replicating the functionality in our project and realized the
method already existed in Flink.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message