flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3665) Range partitioning lacks support to define sort orders
Date Thu, 07 Apr 2016 15:59:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230464#comment-15230464

ASF GitHub Bot commented on FLINK-3665:

Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java
    @@ -546,6 +549,60 @@ public void testRangePartitionInIteration() throws Exception {
     		result.collect(); // should fail
    +	@Test
    +	public void testRangePartitionerOnSequenceDataWithOrders() throws Exception {
    --- End diff --
    we need at least two more tests here:
    - test for range partitioning with key selector and order
    - test for range partitioning with a nested key

> Range partitioning lacks support to define sort orders
> ------------------------------------------------------
>                 Key: FLINK-3665
>                 URL: https://issues.apache.org/jira/browse/FLINK-3665
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataSet API
>    Affects Versions: 1.0.0
>            Reporter: Fabian Hueske
>             Fix For: 1.1.0
> {{DataSet.partitionByRange()}} does not allow to specify the sort order of fields. This
is fine if range partitioning is used to reduce skewed partitioning. 
> However, it is not sufficient if range partitioning is used to sort a data set in parallel.

> Since {{DataSet.partitionByRange()}} is {{@Public}} API and cannot be easily changed,
I propose to add a method {{withOrders(Order... orders)}} to {{PartitionOperator}}. The method
should throw an exception if the partitioning method of {{PartitionOperator}} is not range

This message was sent by Atlassian JIRA

View raw message