flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3665) Range partitioning lacks support to define sort orders
Date Mon, 18 Apr 2016 15:00:28 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245813#comment-15245813

ASF GitHub Bot commented on FLINK-3665:

Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/PartitionNode.java
    @@ -90,13 +90,20 @@ public SemanticProperties getSemanticProperties() {
     		private final PartitionMethod pMethod;
     		private final Partitioner<?> customPartitioner;
     		private final DataDistribution distribution;
    +		private final Ordering ordering;
     		public PartitionDescriptor(PartitionMethod pMethod, FieldSet pKeys, Partitioner<?>
customPartitioner, DataDistribution distribution) {
    --- End diff --
    Can you remove this constructor? I think the optimizer will fail if no `ordering` is set.

> Range partitioning lacks support to define sort orders
> ------------------------------------------------------
>                 Key: FLINK-3665
>                 URL: https://issues.apache.org/jira/browse/FLINK-3665
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataSet API
>    Affects Versions: 1.0.0
>            Reporter: Fabian Hueske
>             Fix For: 1.1.0
> {{DataSet.partitionByRange()}} does not allow to specify the sort order of fields. This
is fine if range partitioning is used to reduce skewed partitioning. 
> However, it is not sufficient if range partitioning is used to sort a data set in parallel.

> Since {{DataSet.partitionByRange()}} is {{@Public}} API and cannot be easily changed,
I propose to add a method {{withOrders(Order... orders)}} to {{PartitionOperator}}. The method
should throw an exception if the partitioning method of {{PartitionOperator}} is not range

This message was sent by Atlassian JIRA

View raw message