flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephan Ewen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3685) Logical error in code for DateSerializer deserialize with reuse
Date Mon, 04 Apr 2016 14:45:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224269#comment-15224269
] 

Stephan Ewen commented on FLINK-3685:
-------------------------------------

Most serializers do not support null, and the runtime does not work with null values either.
This is an "in case support will be added" logic that should be removed in my opinion. Also,
because {{-1}} is actually a valid date.

> Logical error in code for DateSerializer deserialize with reuse
> ---------------------------------------------------------------
>
>                 Key: FLINK-3685
>                 URL: https://issues.apache.org/jira/browse/FLINK-3685
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: ZhengBowen
>
> There is a logical error in the following function in DateSerializer.java when source
read '-1'
> function is:
> ```
> public Date deserialize(Date reuse, DataInputView source) throws IOException {
> 	long v = source.readLong();
> 	if(v == -1L) {
> 		return null;
> 	}
> 	reuse.setTime(v);
> 	return reuse;
> }
> ```
> when call this function for first time, if return null, then 'reuse' will be set null
by caller;
> when call this function for second time,if 'v!=-1' ,reuse.setTime(v) will throw NPE.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message