flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3697) keyBy() with nested POJO computes invalid field position indexes
Date Wed, 06 Apr 2016 09:45:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228041#comment-15228041
] 

ASF GitHub Bot commented on FLINK-3697:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1851#discussion_r58678493
  
    --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamPojoITCase.java
---
    @@ -0,0 +1,211 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.api;
    +
    +import org.apache.flink.api.common.functions.FlatMapFunction;
    +import org.apache.flink.streaming.api.datastream.DataStream;
    +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
    +import org.apache.flink.streaming.api.functions.source.SourceFunction;
    +import org.apache.flink.streaming.util.StreamingMultipleProgramsTestBase;
    +import org.apache.flink.util.Collector;
    +import org.junit.Test;
    +
    +/**
    + * Integration test for streaming programs using POJOs and key selectors
    + *
    + * See FLINK-3697
    + */
    +public class DataStreamPojoITCase extends StreamingMultipleProgramsTestBase {
    +
    +	/**
    +	 * Test composite key on the Data POJO (with nested fields)
    +	 */
    +	@Test
    +	public void testCompositeKeyOnNestedPojo() throws Exception {
    +		StreamExecutionEnvironment see = StreamExecutionEnvironment.getExecutionEnvironment();
    +		see.getConfig().disableObjectReuse();
    +		see.setParallelism(3);
    +
    +		DataStream<Data> dataStream = see.addSource(new DataGenerator());
    --- End diff --
    
    Why not use "fromCollection()" here and have a prepared list of sample data...


> keyBy() with nested POJO computes invalid field position indexes
> ----------------------------------------------------------------
>
>                 Key: FLINK-3697
>                 URL: https://issues.apache.org/jira/browse/FLINK-3697
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API
>    Affects Versions: 1.0.0
>         Environment: MacOS X 10.10
>            Reporter: Ron Crocker
>            Assignee: Robert Metzger
>            Priority: Critical
>              Labels: pojo
>
> Using named keys in keyBy() for nested POJO types results in failure. The iindexes for
named key fields are used inconsistently with nested POJO types. In particular, {{PojoTypeInfo.getFlatFields()}}
returns the field's position after (apparently) flattening the structure but is referenced
in the unflattened version of the POJO type by {{PojoTypeInfo.getTypeAt()}}.
> In the example below, getFlatFields() returns positions 0, 1, and 14. These positions
appear correct in the flattened structure of the Data class. However, in {{KeySelector<X,
Tuple> getSelectorForKeys(Keys<X> keys, TypeInformation<X> typeInfo, ExecutionConfig
executionConfig)}}, a call to {{compositeType.getTypeAt(logicalKeyPositions[i])}} for the
third key results {{PojoTypeInfo.getTypeAt()}} declaring it out of range, as it compares the
length of the directly named fields of the object vs the length of flattened version of that
type.
> Concrete Example:
> Consider this graph:
> {code}
> DataStream<TimesliceData> dataStream = see.addSource(new FlinkKafkaConsumer08<>(timesliceConstants.topic,
new DataDeserialzer(), kafkaConsumerProperties));
> dataStream
>       .flatMap(new DataMapper())
>       .keyBy("aaa", "abc", "wxyz")
> {code}
> {{DataDeserialzer}} returns a "NativeDataFormat" object; {{DataMapper}} takes this NativeDataFormat
object and extracts individual Data objects: {code}
> public class Data {
>     public int aaa;
>     public int abc;
>     public long wxyz;
>     public int t1;
>     public int t2;
>     public Policy policy;
>     public Stats stats;
>     public Data() {}
> {code}
> A {{Policy}} object is an instance of this class:
> {code}
> public class Policy {
>     public short a;
>     public short b;
>     public boolean c;
>     public boolean d;
>     public Policy() {}
> }
> {code}
> A {{Stats}} object is an instance of this class:
> {code}
> public class Stats {
>     public long count;
>     public float a;
>     public float b;
>     public float c;
>     public float d;
>     public float e;
>     public Stats() {}
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message