flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3700) Replace Guava Preconditions class with Flink Preconditions
Date Tue, 05 Apr 2016 13:30:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226246#comment-15226246

ASF GitHub Bot commented on FLINK-3700:

GitHub user StephanEwen opened a pull request:


    [FLINK-3700] [core] Add 'Preconditions' utility class.

    The functionality that Flink uses from Guava is super simple and limited.
    We get a big dependency that has caused a lot of pain in the past, simply to get access
to some simple utility methods. This has cause us quite a bit of pain in the past, because
of Guava version conflicts and the necessary dependency shading.
    In order to reduce the dependency on Guava, this adds a simple Flink Preconditions class.
    While referencing well established libraries is a good idea for standalone apps, it is
a problem for frameworks like Flink, if the dependencies are not well-behaved with respect
to version compatibility. Guava is not well behaved in that sense.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink flink_preconditions

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1853


> Replace Guava Preconditions class with Flink Preconditions
> ----------------------------------------------------------
>                 Key: FLINK-3700
>                 URL: https://issues.apache.org/jira/browse/FLINK-3700
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
> In order to reduce the dependency on Guava (which has cause us quite a bit of pain in
the past with its version conflicts), I suggest to add a Flink {{Preconditions}} class.

This message was sent by Atlassian JIRA

View raw message