flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aljoscha Krettek (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3747) Consolidate TimestampAssigner Methods in Kafka Consumer
Date Wed, 13 Apr 2016 09:31:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238947#comment-15238947
] 

Aljoscha Krettek commented on FLINK-3747:
-----------------------------------------

will do


> Consolidate TimestampAssigner Methods in Kafka Consumer
> -------------------------------------------------------
>
>                 Key: FLINK-3747
>                 URL: https://issues.apache.org/jira/browse/FLINK-3747
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>
> On {{DataStream}} the methods for setting a TimestampAssigner/WatermarkEmitter are called
{{assignTimestampsAndWatermarks()}} while on {{FlinkKafkaConsumer*}} they are called {{setPunctuatedWatermarkEmitter()}}
and {{setPeriodicWatermarkEmitter()}}.
> I think these names should be matched, also the name {{setWatermarkEmitter}} does not
hint at the fact that the assigner primarily assigns timestamps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message