flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3747) Consolidate TimestampAssigner Methods in Kafka Consumer
Date Wed, 13 Apr 2016 09:42:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238968#comment-15238968
] 

ASF GitHub Bot commented on FLINK-3747:
---------------------------------------

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/1877

    [FLINK-3747] Consolidate TimestampAssigner Methods in Kafka Consumer

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink kafka-fix-assigner

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1877.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1877
    
----
commit dea8fe24338ac74db595194999eaea4dca9e32e1
Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Date:   2016-04-13T09:41:39Z

    [FLINK-3747] Consolidate TimestampAssigner Methods in Kafka Consumer

----


> Consolidate TimestampAssigner Methods in Kafka Consumer
> -------------------------------------------------------
>
>                 Key: FLINK-3747
>                 URL: https://issues.apache.org/jira/browse/FLINK-3747
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>
> On {{DataStream}} the methods for setting a TimestampAssigner/WatermarkEmitter are called
{{assignTimestampsAndWatermarks()}} while on {{FlinkKafkaConsumer*}} they are called {{setPunctuatedWatermarkEmitter()}}
and {{setPeriodicWatermarkEmitter()}}.
> I think these names should be matched, also the name {{setWatermarkEmitter}} does not
hint at the fact that the assigner primarily assigns timestamps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message