flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector
Date Mon, 04 Jul 2016 05:18:01 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1813#discussion_r69409088
  
    --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisCommandsContainerBuilder.java
---
    @@ -0,0 +1,95 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.streaming.connectors.redis.common.container;
    +
    +import org.apache.commons.pool2.impl.GenericObjectPoolConfig;
    +import org.apache.flink.streaming.connectors.redis.common.config.FlinkJedisClusterConfig;
    +import org.apache.flink.streaming.connectors.redis.common.config.FlinkJedisPoolConfig;
    +import org.apache.flink.streaming.connectors.redis.common.config.FlinkJedisSentinelConfig;
    +import org.apache.flink.util.Preconditions;
    +import redis.clients.jedis.JedisCluster;
    +import redis.clients.jedis.JedisPool;
    +import redis.clients.jedis.JedisSentinelPool;
    +
    +/**
    + * The builder for {@link RedisCommandsContainer}.
    + */
    +public class RedisCommandsContainerBuilder {
    +
    +	/**
    +	 * Builds container for single Redis environment.
    +	 *
    +	 * @param jedisPoolConfig configuration for JedisPool
    +	 * @return container for single Redis environment
    +	 * @throws NullPointerException if jedisPoolConfig is null
    +	 */
    +	public static RedisCommandsContainer build(FlinkJedisPoolConfig jedisPoolConfig) {
    --- End diff --
    
    Perhaps the `build` functions can make use of the `FlinkJedisConfigBase` too?
    This way `RedisSink#open()` can be even more simpler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message