flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjsax <...@git.apache.org>
Subject [GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector
Date Mon, 04 Jul 2016 09:17:20 GMT
Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1813#discussion_r69430042
  
    --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/FlinkJedisSentinelConfig.java
---
    @@ -0,0 +1,267 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.streaming.connectors.redis.common.config;
    +
    +import org.apache.commons.pool2.impl.GenericObjectPoolConfig;
    +import org.apache.flink.util.Preconditions;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import redis.clients.jedis.Protocol;
    +
    +import java.util.Set;
    +
    +/**
    + * Configuration for Jedis Sentinel Pool.
    + */
    +public class FlinkJedisSentinelConfig extends FlinkJedisConfigBase {
    +	private static final long serialVersionUID = 1L;
    +
    +	private static final Logger LOG = LoggerFactory.getLogger(FlinkJedisSentinelConfig.class);
    +
    +	private String masterName;
    +	private Set<String> sentinels;
    +	private int soTimeout;
    +	private String password;
    +	private int database;
    +
    +	/**
    +	 * Jedis Sentinels config.
    +	 * The master name and sentinels are mandatory, and when you didn't set these, it throws
NullPointerException.
    +	 *
    +	 * @param masterName master name of the replica set
    +	 * @param sentinels set of sentinel hosts
    +	 * @param connectionTimeout timeout connection timeout
    +	 * @param soTimeout timeout socket timeout
    +	 * @param password password, if any
    +	 * @param database database database index
    +	 * @param maxTotal maxTotal the maximum number of objects that can be allocated by the
pool
    +	 * @param maxIdle the cap on the number of "idle" instances in the pool
    +	 * @param minIdle the minimum number of idle objects to maintain in the pool
    +	 *
    +	 * @throws NullPointerException if {@code masterName} or {@code sentinels} is {@code
null}
    +	 * @throws IllegalArgumentException if {@code sentinels} are empty
    +	 */
    +	private FlinkJedisSentinelConfig(String masterName, Set<String> sentinels,
    +									int connectionTimeout, int soTimeout,
    +									String password, int database,
    +									int maxTotal, int maxIdle, int minIdle) {
    +		super(connectionTimeout, maxTotal, maxIdle, minIdle);
    +		Preconditions.checkNotNull(masterName, "Master name should be presented");
    +		Preconditions.checkNotNull(sentinels, "Sentinels information should be presented");
    +		Preconditions.checkArgument(!sentinels.isEmpty(), "Sentinel hosts should not be empty");
    +
    +		this.masterName = masterName;
    +		this.sentinels = sentinels;
    --- End diff --
    
    Should we copy this `Set` to guard against external modifications?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message