flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink issue #2183: [FLINK-4123] Cassandra sink checks for exceptions in ack ...
Date Mon, 04 Jul 2016 10:51:49 GMT
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2183
  
    I have one final remark concerning the busy wait loop. I think it's better to replace
it with a wait-notify construct. Maybe we could also add a test which assures that the `sendValues`
loop is left in case of an exception.
    
    After addressing this comment, I think the PR is good to be merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message