flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl0u <...@git.apache.org>
Subject [GitHub] flink issue #2109: [FLINK-3677] FileInputFormat: Allow to specify include/ex...
Date Fri, 08 Jul 2016 14:54:38 GMT
Github user kl0u commented on the issue:

    https://github.com/apache/flink/pull/2109
  
    1) If it is to include it, then I would suggest to just replace the DefaultFilter with
that, and probably give some initial patterns for e.g. hidden files (start with "."). Having
two implementations, both serving as default implementations in different parts of the code
it seems a bit confusing.
    
    2) shouldIgnore() assumes we already have the lock and it is applied entirely within it,
so it will not harm to remove it.
    
    3) The method to change is the `createFileInput(FileInputFormat<OUT> inputFormat,
TypeInformation<OUT> typeInfo, String sourceName,  FileProcessingMode watchType, FilePathFilter
pathFilter, long interval)` which creates the `ContinuousFileMonitoringFunction` .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message