flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #2279: [FLINK-4229] Only start JMX server when port is sp...
Date Thu, 21 Jul 2016 14:49:34 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2279#discussion_r71720105
  
    --- Diff: flink-core/src/test/java/org/apache/flink/metrics/reporter/JMXReporterTest.java
---
    @@ -88,7 +88,7 @@ public void testPortConflictHandling() throws Exception {
     		JMXReporter rep2 = new JMXReporter();
     
     		Configuration cfg1 = new Configuration();
    -		cfg1.setString(ConfigConstants.METRICS_REPORTER_ARGUMENTS, "-port 9020-9035");
    +		cfg1.setString("port", "9020-9035");
    --- End diff --
    
    The change of only starting a server when the ports are present should not change the
config keys, correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message