flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #2285: [FLINK-4246] Allow Specifying Multiple Metrics Rep...
Date Fri, 22 Jul 2016 14:04:18 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2285#discussion_r71883403
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
    @@ -51,9 +51,11 @@ public void testJobManagerMetricAccess() throws Exception {
     		Deadline deadline = new FiniteDuration(2, TimeUnit.MINUTES).fromNow();
     		Configuration flinkConfiguration = new Configuration();
     
    -		flinkConfiguration.setString(ConfigConstants.METRICS_REPORTER_CLASS, "org.apache.flink.metrics.reporter.JMXReporter");
    +		flinkConfiguration.setString(ConfigConstants.METRICS_REPORTERS_LIST, "test");
    +		flinkConfiguration.setString(ConfigConstants.METRICS_REPORTER_PREFIX + "test.class",
"org.apache.flink.metrics.reporter.JMXReporter");
    --- End diff --
    
    shouldn't we uses the ConfigConstants.METRICS_REPORTER_CLASS here instead of `.class`
? I know it blows up the line, but it still is a defined constant. (the same applies to ExecutionGraphMetricsTest)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message