flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshfg <...@git.apache.org>
Subject [GitHub] flink issue #2269: [FLINK-4190] Generalise RollingSink to work with arbitrar...
Date Mon, 25 Jul 2016 09:50:31 GMT
Github user joshfg commented on the issue:

    https://github.com/apache/flink/pull/2269
  
    Thanks! Oh nice, this looks like a better solution for checking for bucket inactivity...
    For the tests, is there any reason not to fold all of those tests into the new `BucketingSinkTest`?
Currently there's 4: (BucketingSinkITCase, BucketingSinkFaultToleranceITCase, BucketingSinkFaultTolerance2ITCase,
BucketingSinkMultipleActiveBucketsCase)
    
    Also, do you know what's the purpose of using MiniDFSCluster in the tests? Could we rewrite
the other tests in the same way as your example test, without running a local HDFS cluster?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message