flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #2277: [FLINK-4207] WindowOperator becomes very slow with...
Date Mon, 25 Jul 2016 16:06:26 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2277#discussion_r72092981
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/AppendingState.java
---
    @@ -46,8 +46,14 @@
     	 * operator instance. If state partitioning is applied, the value returned
     	 * depends on the current operator input, as the operator maintains an
     	 * independent state for each partition.
    -	 * 
    -	 * @return The operator state value corresponding to the current input.
    +	 *
    +	 * <p>
    +	 *     <b>NOTE TO IMPLEMENTERS:</b> if the state is empty, then this method
    +	 *     should return {@code null}.
    +	 * </p>
    +	 *
    +	 * @return The operator state value corresponding to the current input or {@code null}
    +	 * is the state is empty.
    --- End diff --
    
    Good idea to include this message!
    
    There's a type, though, should be "if the state is empty" 😉 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message