flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #2277: [FLINK-4207] WindowOperator becomes very slow with...
Date Mon, 25 Jul 2016 16:07:45 GMT
Github user aljoscha commented on a diff in the pull request:

    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/MergingWindowSet.java
    @@ -80,8 +80,10 @@ public MergingWindowSet(MergingWindowAssigner<?, W> windowAssigner,
     		this.windowAssigner = windowAssigner;
     		windows = new HashMap<>();
    -		for (Tuple2<W, W> window: state.get()) {
    -			windows.put(window.f0, window.f1);
    +		if (state.get() != null) {
    --- End diff --
    Two `state.get()` calls, can be reduced to one.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message