flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2275: FLINK-3929 Support for Kerberos Authentication wit...
Date Wed, 27 Jul 2016 14:27:32 GMT
Github user mxm commented on a diff in the pull request:

    --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/RunTypeSelectionRunner.java
    @@ -0,0 +1,54 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.test.util;
    +import org.junit.runners.BlockJUnit4ClassRunner;
    +import org.junit.runners.model.FrameworkMethod;
    +import org.junit.runners.model.InitializationError;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    + * Custom JRunner used to run integration tests for Kafka in secure mode. Since the test
code implementation uses
    + * abstract base code to run the MiniFlinkCluster and also start/stop Kafka brokers depending
on the version (0.8/0.9)
    + * we need to know the run mode (CLEAR/SECURE) ahead of time (before the beforeClass).
This Runner instance
    + * take care of setting SECURE flag on the holder class for secure testing to work seamless
    + *
    + */
    +public class RunTypeSelectionRunner extends BlockJUnit4ClassRunner {
    --- End diff --
    This seems a bit complicated. Why don't we setup the secure utilities in `@BeforeClass`
and `@AfterClass` methods in the test classes? I think this would be easier to understand.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message