flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3034) Redis SInk Connector
Date Mon, 04 Jul 2016 09:30:11 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361081#comment-15361081
] 

ASF GitHub Bot commented on FLINK-3034:
---------------------------------------

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1813#discussion_r69431563
  
    --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkITCase.java
---
    @@ -0,0 +1,240 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.streaming.connectors.redis;
    +
    +import org.apache.flink.api.java.tuple.Tuple2;
    +import org.apache.flink.streaming.api.datastream.DataStreamSource;
    +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
    +import org.apache.flink.streaming.api.functions.source.SourceFunction;
    +import org.apache.flink.streaming.connectors.redis.common.config.FlinkJedisClusterConfig;
    +import org.apache.flink.streaming.connectors.redis.common.config.FlinkJedisPoolConfig;
    +import org.apache.flink.streaming.connectors.redis.common.mapper.RedisCommand;
    +import org.apache.flink.streaming.connectors.redis.common.mapper.RedisCommandDescription;
    +import org.apache.flink.streaming.connectors.redis.common.mapper.RedisMapper;
    +import org.junit.After;
    +import org.junit.Before;
    +import org.junit.Test;
    +import redis.clients.jedis.Jedis;
    +
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertNull;
    +
    +public class RedisSinkITCase extends RedisITCaseBase {
    +
    +	private FlinkJedisPoolConfig jedisPoolConfig;
    +	private static final Long NUM_ELEMENTS = 20L;
    +	private static final String REDIS_KEY = "TEST_KEY";
    +	private static final String REDIS_ADDITIONAL_KEY = "TEST_ADDITIONAL_KEY";
    +
    +	StreamExecutionEnvironment env;
    +
    +
    +	private Jedis jedis;
    +
    +	@Before
    +	public void setUp(){
    +		jedisPoolConfig = new FlinkJedisPoolConfig.Builder()
    +			.setHost(REDIS_HOST)
    +			.setPort(REDIS_PORT).build();
    +		jedis = new Jedis(REDIS_HOST, REDIS_PORT);
    +		env = StreamExecutionEnvironment.getExecutionEnvironment();
    +	}
    +
    +	@Test
    +	public void testRedisListDataType() throws Exception {
    +		DataStreamSource<Tuple2<String, String>> source = env.addSource(new TestSourceFunction());
    +		RedisSink<Tuple2<String, String>> redisSink = new RedisSink<>(jedisPoolConfig,
    +			new RedisCommandMapper(RedisCommand.LPUSH));
    +
    +		source.addSink(redisSink);
    +		env.execute("Test Redis List Data Type");
    +
    +		assertEquals(NUM_ELEMENTS, jedis.llen(REDIS_KEY));
    +
    +		jedis.del(REDIS_KEY);
    +	}
    +
    +	@Test
    +	public void testRedisSetDataType() throws Exception {
    +		DataStreamSource<Tuple2<String, String>> source = env.addSource(new TestSourceFunction());
    +		RedisSink<Tuple2<String, String>> redisSink = new RedisSink<>(jedisPoolConfig,
    +			new RedisCommandMapper(RedisCommand.SADD));
    +
    +		source.addSink(redisSink);
    +		env.execute("Test Redis Set Data Type");
    +
    +		assertEquals(NUM_ELEMENTS, jedis.scard(REDIS_KEY));
    +
    +		jedis.del(REDIS_KEY);
    +	}
    +
    +	@Test
    +	public void testRedisHyperLogLogDataType() throws Exception {
    +		DataStreamSource<Tuple2<String, String>> source = env.addSource(new TestSourceFunction());
    +		RedisSink<Tuple2<String, String>> redisSink = new RedisSink<>(jedisPoolConfig,
    +			new RedisCommandMapper(RedisCommand.PFADD));
    +
    +		source.addSink(redisSink);
    +		env.execute("Test Redis Hyper Log Log Data Type");
    +
    +		assertEquals(NUM_ELEMENTS, Long.valueOf(jedis.pfcount(REDIS_KEY)));
    +
    +		jedis.del(REDIS_KEY);
    +	}
    +
    +	@Test
    +	public void testRedisSortedSetDataType() throws Exception {
    +		DataStreamSource<Tuple2<String, String>> source = env.addSource(new TestSourceFunctionSortedSet());
    +		RedisSink<Tuple2<String, String>> redisSink = new RedisSink<>(jedisPoolConfig,
    +			new RedisAdditionalDataMapper(RedisCommand.ZADD));
    +
    +		source.addSink(redisSink);
    +		env.execute("Test Redis Sorted Set Data Type");
    +
    +		assertEquals(NUM_ELEMENTS, jedis.zcard(REDIS_ADDITIONAL_KEY));
    +
    +		jedis.del(REDIS_ADDITIONAL_KEY);
    +	}
    +
    +	@Test
    +	public void testRedisHashDataType() throws Exception {
    +		DataStreamSource<Tuple2<String, String>> source = env.addSource(new TestSourceFunctionHash());
    +		RedisSink<Tuple2<String, String>> redisSink = new RedisSink<>(jedisPoolConfig,
    +			new RedisAdditionalDataMapper(RedisCommand.HSET));
    +
    +		source.addSink(redisSink);
    +		env.execute("Test Redis Hash Data Type");
    +
    +		assertEquals(NUM_ELEMENTS, jedis.hlen(REDIS_ADDITIONAL_KEY));
    +
    +		jedis.del(REDIS_ADDITIONAL_KEY);
    +	}
    +
    +	@Test(expected=NullPointerException.class)
    +	public void shouldThrowNullPointExceptionIfDataMapperIsNull(){
    --- End diff --
    
    This should go into a unit test -- not an integration test.


> Redis SInk Connector
> --------------------
>
>                 Key: FLINK-3034
>                 URL: https://issues.apache.org/jira/browse/FLINK-3034
>             Project: Flink
>          Issue Type: New Feature
>          Components: Streaming Connectors
>            Reporter: Matthias J. Sax
>            Assignee: Subhankar Biswas
>            Priority: Minor
>
> Flink does not provide a sink connector for Redis.
> See FLINK-3033



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message