flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns
Date Fri, 08 Jul 2016 14:55:11 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367780#comment-15367780
] 

ASF GitHub Bot commented on FLINK-3677:
---------------------------------------

Github user kl0u commented on the issue:

    https://github.com/apache/flink/pull/2109
  
    1) If it is to include it, then I would suggest to just replace the DefaultFilter with
that, and probably give some initial patterns for e.g. hidden files (start with "."). Having
two implementations, both serving as default implementations in different parts of the code
it seems a bit confusing.
    
    2) shouldIgnore() assumes we already have the lock and it is applied entirely within it,
so it will not harm to remove it.
    
    3) The method to change is the `createFileInput(FileInputFormat<OUT> inputFormat,
TypeInformation<OUT> typeInfo, String sourceName,  FileProcessingMode watchType, FilePathFilter
pathFilter, long interval)` which creates the `ContinuousFileMonitoringFunction` .


> FileInputFormat: Allow to specify include/exclude file name patterns
> --------------------------------------------------------------------
>
>                 Key: FLINK-3677
>                 URL: https://issues.apache.org/jira/browse/FLINK-3677
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Maximilian Michels
>            Assignee: Ivan Mushketyk
>            Priority: Minor
>              Labels: starter
>
> It would be nice to be able to specify a regular expression to filter files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message